erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

storm: make sure board ID is calculated only once

Browse source 
Figuring out board_id on storm requires reading tertiary gpios, which
takes time. Let's calculate it once and reuse it when necessary.

BUG=none
TEST=verified board ID reported as 0 and 1 on proto0 and proto0.2
     respectively.

Change-Id: I4e237077d1d9a96daebba462cd00f3f40be14518
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/217086
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: David Hendricks <dhendrix@chromium.org>
This commit is contained in:
Vadim Bendebury 2014-09-08 14:04:08 -07:00 • committed by chrome-internal-fetch
commit 080c839c1c
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/mainboard/google/storm/boardid.c
View file

@ -37,7 +37,9 @@
* revision.
*/
uint8_t board_id(void)
static int board_id_value = -1;
static uint8_t get_board_id(void)
{
uint8_t bid;
gpio_t hw_rev_gpios[] = {29, 30, 68};
@ -50,3 +52,11 @@ uint8_t board_id(void)
return bid;
}
uint8_t board_id(void)
{
if (board_id_value < 0)
board_id_value = get_board_id();
return board_id_value;
}