From 077191641befb8b4e28af13dea18bdfc05602d56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20=C5=BBygowski?= Date: Mon, 6 Oct 2025 14:21:03 +0200 Subject: [PATCH] vendorcode/amd/opensil/Makefile.mk: Add 0x prefix for BIOS address MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Makefile is patching the BIOS moudule base address and size so that the openSIL knows where the reset vector resides. However, the printf used for hex convertion is missing 0x prefix for hexvalue. Kconfig hex values start with 0x prefix. Otherwise, there is a chance the bios_base variable could be interpreted as decimal integer. This could result in improper reset vector address being calculated in OpenSIL and APs not able to be brought up. Change-Id: Ib528491b266ec2e8d74b9c8713788f8f37037162 Signed-off-by: Michał Żygowski Reviewed-on: https://review.coreboot.org/c/coreboot/+/89472 Reviewed-by: Matt DeVillier Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) Reviewed-by: Alicja Michalska --- src/vendorcode/amd/opensil/Makefile.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vendorcode/amd/opensil/Makefile.mk b/src/vendorcode/amd/opensil/Makefile.mk index 3e8661d804..5c881f9bc6 100644 --- a/src/vendorcode/amd/opensil/Makefile.mk +++ b/src/vendorcode/amd/opensil/Makefile.mk @@ -53,7 +53,7 @@ PYTHON?=python OPENSIL_CONFIG=opensil_config -bios_base=$(shell printf "%x" $(call int-subtract, $(CONFIG_ROMSTAGE_ADDR) $(CONFIG_C_ENV_BOOTBLOCK_SIZE))) +bios_base=$(shell printf "0x%x" $(call int-subtract, $(CONFIG_ROMSTAGE_ADDR) $(CONFIG_C_ENV_BOOTBLOCK_SIZE))) bios_size=$(CONFIG_C_ENV_BOOTBLOCK_SIZE) $(OBJPATH)/$(OPENSIL_CONFIG): $(opensil_dir)/../opensil_config.template