From 075a13b775718191e3399e012837c4f394e6a5d8 Mon Sep 17 00:00:00 2001 From: Varun Upadhyay Date: Tue, 3 Dec 2024 00:22:38 +0530 Subject: [PATCH] mb/google/fatcat: Update Soundwire codec address based on devicetree This change adds soundwire codec addresses in the devicetree to calculate addresses for the ACPI table instead of previous kconfig which allows single board to select multiple soundwire codecs at runtime based on FW_CONFIG. BUG=b:368495490 TEST=build coreboot image and boot on google fatcat. Disassemble SSDT and confirm ACPI entries are correct for alc7xx device. Change-Id: I3322ae2d106d3628dbf627aacf999056d82ee7a9 Signed-off-by: Varun Upadhyay Signed-off-by: Naveen M Reviewed-on: https://review.coreboot.org/c/coreboot/+/85440 Reviewed-by: Karthik Ramasubramanian Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik --- src/mainboard/google/fatcat/Kconfig | 2 +- .../google/fatcat/variants/fatcat/overridetree.cb | 11 ++++++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/fatcat/Kconfig b/src/mainboard/google/fatcat/Kconfig index a67ea3b5f8..3ab4be007e 100644 --- a/src/mainboard/google/fatcat/Kconfig +++ b/src/mainboard/google/fatcat/Kconfig @@ -10,7 +10,7 @@ config BOARD_GOOGLE_FATCAT_COMMON select DRIVERS_INTEL_SOUNDWIRE select DRIVERS_WWAN_FM350GL select DRIVERS_AUDIO_SOF - select DRIVERS_SOUNDWIRE_ALC722 + select DRIVERS_SOUNDWIRE_ALC_BASE_7XX select DRIVERS_SPI_ACPI select DUMP_SMBIOS_TYPE17 select EC_ACPI diff --git a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb index fba49fdb45..26490f110c 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb @@ -621,11 +621,20 @@ chip soc/intel/pantherlake chip drivers/intel/soundwire device generic 0 on chip drivers/soundwire/alc711 - # SoundWire Link 1 ID 1 register "desc" = ""Headset Codec"" + register "alc711_address.version" = "SOUNDWIRE_VERSION_1_2" + register "alc711_address.class" = "MIPI_CLASS_SDCA" + register "alc711_address.part_id" = "MIPI_DEV_ID_REALTEK_ALC722" + # SoundWire Link 1 ID 1 device generic 1.1 on probe AUDIO AUDIO_ALC722_SNDW end + end + chip drivers/soundwire/alc711 + register "desc" = ""Headset Codec"" + register "alc711_address.version" = "SOUNDWIRE_VERSION_1_2" + register "alc711_address.class" = "MIPI_CLASS_SDCA" + register "alc711_address.part_id" = "MIPI_DEV_ID_REALTEK_ALC721" # SoundWire Link 3 ID 1 device generic 3.1 on probe AUDIO AUDIO_ALC721_SNDW