From 07081c5c67a01284f1c1e3ff437e0ffe39e4a41e Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Wed, 6 Jul 2016 22:41:24 -0500 Subject: [PATCH] UPSTREAM: soc/intel/apollolake: make internal pulls weak for gpio inputs The internal pulls for gpio_input_pullup() and gpio_input_pulldown() were using fairly strong pulls. Weaken them so that external pulls can override the internal ones. This matches the current assumptions of lib/gpio.c. BUG=chrome-os-partner:54949 BRANCH=None TEST=Built and used on reef for memory config. BUG=None BRANCH=None TEST=None Change-Id: Ifda1d04d40141325f78db277eb0bd55574994abf Original-Signed-off-by: Aaron Durbin Original-Reviewed-on: https://review.coreboot.org/15558 Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Paul Menzel Original-Reviewed-by: Andrey Petrov Original-Reviewed-by: Furquan Shaikh Signed-off-by: Aaron Durbin Reviewed-on: https://chromium-review.googlesource.com/358893 Reviewed-by: Furquan Shaikh --- src/soc/intel/apollolake/gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/soc/intel/apollolake/gpio.c b/src/soc/intel/apollolake/gpio.c index 525c972b5c..699c8fea28 100644 --- a/src/soc/intel/apollolake/gpio.c +++ b/src/soc/intel/apollolake/gpio.c @@ -71,13 +71,13 @@ void gpio_configure_pads(const struct pad_config *cfg, size_t num_pads) void gpio_input_pulldown(gpio_t gpio) { - struct pad_config cfg = PAD_CFG_GPI(gpio, DN_5K, DEEP); + struct pad_config cfg = PAD_CFG_GPI(gpio, DN_20K, DEEP); gpio_configure_pad(&cfg); } void gpio_input_pullup(gpio_t gpio) { - struct pad_config cfg = PAD_CFG_GPI(gpio, UP_5K, DEEP); + struct pad_config cfg = PAD_CFG_GPI(gpio, UP_20K, DEEP); gpio_configure_pad(&cfg); }