From 070447049a9f5ac06781cf8e924e75ec30e43790 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Tue, 1 Apr 2025 21:21:39 +0100 Subject: [PATCH] mb/starlabs/starbook/adl_n: Tidy GPIO comments for the SMBUS This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: I8456c5fa72d0c8620469e9c9ea260c60100db40e Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/87079 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/mainboard/starlabs/starbook/variants/adl_n/gpio.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 514d2d84c7..e7a68c2758 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -74,6 +74,11 @@ const struct pad_config gpio_table[] = { /* TPM */ PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* Interrupt */ + /* SMBus */ + PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), /* Clock */ + PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* Data */ + PAD_CFG_GPO(GPP_E8, 1, DEEP), /* DRAM Sleep */ + PAD_NC(GPD2, NONE), PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ @@ -157,10 +162,6 @@ const struct pad_config gpio_table[] = { /* B25: Not Connected */ PAD_NC(GPP_B25, NONE), - /* C0: SMB Clock */ - PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), - /* C1: SMB Data */ - PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* C2: TLS Confidentiality Weak Internal PD 20K Low: Disabled High: Enabled */ @@ -261,8 +262,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_E6, 0, DEEP), /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), - /* E8: DRAM Sleep */ - PAD_CFG_GPO(GPP_E8, 1, DEEP), /* E9: USB OverCurrent 0 */ PAD_NC(GPP_E9, NONE), /* E10: PWD Amplifier Input */