From 06f3c07a25d9bd5064bbaf22bff15bba5bf4422c Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Fri, 14 Mar 2025 08:32:06 +0000 Subject: [PATCH] soc/intel/alderlake: Correct setting of PchUnlockGpioPads This should be set to the opposite of lockdown_by_fsp. Change-Id: I9e3c8f03ca14d2cb28c3f2f9bd74618d81e53d2c Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/86854 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/soc/intel/alderlake/fsp_params.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index 0de9fe4f66..6b652f65fd 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -667,7 +667,7 @@ static void fill_fsps_chipset_lockdown_params(FSP_S_CONFIG *s_cfg, const bool lockdown_by_fsp = get_lockdown_config() == CHIPSET_LOCKDOWN_FSP; s_cfg->PchLockDownGlobalSmi = lockdown_by_fsp; s_cfg->PchLockDownBiosInterface = lockdown_by_fsp; - s_cfg->PchUnlockGpioPads = lockdown_by_fsp; + s_cfg->PchUnlockGpioPads = !lockdown_by_fsp; s_cfg->RtcMemoryLock = lockdown_by_fsp; s_cfg->SkipPamLock = !lockdown_by_fsp;