From 04b9627e07f1a25ca3a5af75e60062e49cfef7ba Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Thu, 24 Oct 2024 14:08:24 +0100 Subject: [PATCH] drivers/usb/intel_bluetooth: Fix GBTE to return Local0 `acpigen_soc_get_tx_gpio` will put the result into Local0, rather than emitting it as a byte so adjust the function accordingly. Change-Id: I13263d479d1a4520abaf1b6b38514d021e7d4dc9 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/84989 Tested-by: build bot (Jenkins) Reviewed-by: Nicholas Sudsgaard --- src/drivers/usb/acpi/intel_bluetooth.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/drivers/usb/acpi/intel_bluetooth.c b/src/drivers/usb/acpi/intel_bluetooth.c index aa3b7949ab..978d6ee10e 100644 --- a/src/drivers/usb/acpi/intel_bluetooth.c +++ b/src/drivers/usb/acpi/intel_bluetooth.c @@ -326,11 +326,12 @@ void acpi_device_intel_bt_common(unsigned int enable_gpio) */ acpigen_write_method("GBTE", 0); { - acpigen_emit_byte(RETURN_OP); - if (enable_gpio) + if (enable_gpio) { acpigen_soc_get_tx_gpio(enable_gpio); - else - acpigen_emit_byte(0); + acpigen_write_return_op(LOCAL0_OP); + } else { + acpigen_write_return_integer(0); + } } acpigen_pop_len();