erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/bluey: Refactor and secure low-power charging boot path

Browse source 
Refactor the low-power/off-mode charging logic into a dedicated
helper function `handle_low_power_charging_boot`.

Additionally, replace the `return` statement with `halt()` after
the charging applet logic. This ensures that if the system is in
a low-power charging state, it cannot accidentally proceed with
the rest of the mainboard initialization, which could lead to
unstable behavior or power-sequencing issues.

Included <halt.h> to provide the necessary definition.

BUG=none
BRANCH=none
TEST=Build and boot on google/quartz. Verify that low-battery boot
correctly enters the charging applet and does not proceed to full init.

Change-Id: I4bf9bb0f89d117fea9b81a5f8369fa23043a1e82
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/91599
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
This commit is contained in:
Subrata Banik 2026-03-08 09:06:57 +00:00
commit 0449fb45a6
1 changed files with 25 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

38
src/mainboard/google/bluey/mainboard.c
View file

@ -13,6 +13,7 @@
#include <device/i2c_simple.h>
#include <ec/google/chromeec/ec.h>
#include <gpio.h>
#include <halt.h>
#include <soc/clock.h>
#include <soc/pcie.h>
#include <soc/qupv3_config_common.h>
@ -177,6 +178,28 @@ static void trigger_critical_battery_shutdown(void)
google_chromeec_ap_poweroff();
}
/*
* Handle charging and UI states for low-power or off-mode boot scenarios.
* This function handles the transitions needed when the device is powered
* solely to show a charging status rather than a full OS boot.
*/
static void handle_low_power_charging_boot(void)
{
/* TODO: enable fast charging */
enable_slow_battery_charging();
/*
* Disable the lightbar for Low-Battery or Off-Mode charging sequences.
* This maintains visual consistency between the built-in display
* indicators and the external lightbar.
*/
if (CONFIG(EC_GOOGLE_CHROMEEC_LED_CONTROL))
google_chromeec_lightbar_off();
/* Boot to charging applet; if this fails, the applet should trigger a reset */
launch_charger_applet();
}
static void mainboard_init(struct device *dev)
{
configure_parallel_charging();
@ -198,19 +221,8 @@ static void mainboard_init(struct device *dev)
/* Skip mainboard initialization if boot mode is "low-battery" or "off-mode charging" */
if (is_low_power_boot_with_charger()) {
/* TODO: enable fast charging */
enable_slow_battery_charging();
/* Disable the lightbar for Low-Battery or Off-Mode charging sequences.
* This maintains visual consistency between the built-in display
* indicators and the external lightbar.
*/
if (CONFIG(EC_GOOGLE_CHROMEEC_LED_CONTROL))
google_chromeec_lightbar_off();
/* Boot to charging applet */
launch_charger_applet();
return;
handle_low_power_charging_boot();
halt();
}
gpi_firmware_load(QUP_0_GSI_BASE);