UPSTREAM: lenovo/x200,t400: enable C4 cpu low power state

This enables the C4 low power state on the lenovo x200 and t400.
It's inspired by the thread on the mailinglist:
"[coreboot] Lenovo X200 running Coreboot drains 3-4W more power
than with Vendor BIOS".

What this does, is to enable a C3 state using MWAIT(C3) request
and set the southbridge config c4onc3_enable to automatically
upgrade C3 to the lower power C4 state.
The latency (0x37) is the same value used by the vendor bios.

With C4 enabled the idle power consumption is about ~2-3W lower.

TEST= build and install on target. Use powertop top to measure power
usage. To manually disable c-state to compare them,
do (tested on linux 4.4):
echo 1 > /sys/devices/system/cpu/cpu*/cpuidle/stateX/disable

BUG=None
BRANCH=None

Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/15251
Tested-by: build bot (Jenkins)
Reviewed-by: Swift Geek
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Nico Huber <nico.h@gmx.de>

Change-Id: I1a1663a7662ebc7157a965667680688ad6a33545
Reviewed-on: https://chromium-review.googlesource.com/377604
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>

src/mainboard/lenovo/t400/cstates.c

@@ -28,6 +28,11 @@ static acpi_cstate_t cst_entries[] = {
 		2, 0x01,  500,
 		{ ACPI_ADDRESS_SPACE_FIXED, 1, 2, { 1 }, 0x10, 0 }
 	},
+	{
+		/* acpi C3 / cpu C3 */
+		3, 0x37,  250,
+		{ ACPI_ADDRESS_SPACE_FIXED, 1, 2, { 1 }, 0x20, 0 }
+	},
 };
 
 int get_cst_entries(acpi_cstate_t **entries)

src/mainboard/lenovo/t400/devicetree.cb

@@ -63,7 +63,7 @@ chip northbridge/intel/gm45
 			register "sata_traffic_monitor"		= "0"
 
 			# Set c-state support
-			register "c4onc3_enable"		= "0"
+			register "c4onc3_enable"		= "1"
 			register "c5_enable"			= "1"
 			register "c6_enable"			= "1"
 

src/mainboard/lenovo/x200/cstates.c

@@ -28,6 +28,11 @@ static acpi_cstate_t cst_entries[] = {
 		2, 0x01,  500,
 		{ ACPI_ADDRESS_SPACE_FIXED, 1, 2, { 1 }, 0x10, 0 }
 	},
+	{
+		/* acpi C3 / cpu C3 */
+		3, 0x37,  250,
+		{ ACPI_ADDRESS_SPACE_FIXED, 1, 2, { 1 }, 0x20, 0 }
+	},
 };
 
 int get_cst_entries(acpi_cstate_t **entries)

src/mainboard/lenovo/x200/devicetree.cb

@@ -67,7 +67,7 @@ chip northbridge/intel/gm45
 			register "sata_traffic_monitor"		= "0"
 
 			# Set c-state support
-			register "c4onc3_enable"		= "0"
+			register "c4onc3_enable"		= "1"
 			register "c5_enable"			= "1"
 			register "c6_enable"			= "1"