erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/common: Apply Intel recommendation for early ramtop caching

Browse source 
Configuring the Early Caching Ramtop range as Write-Back (WB) before
memory initialization is NOT RECOMMENDED. Speculative execution within
this WB range can lead to issues. WB configuration should be applied
to this range ONLY AFTER memory initialization is complete.

To enable Ramtop caching before memory initialization, use
Write-Combining (WC) instead of Write-Back (WB).

This change applies the recommendation by always configuring the early
ramtop caching range as WC.

BUG=b:373290479
TEST=Able to build and boot google/trulo.

Change-Id: Idf6f0be1bc0daa8037ea9c52932eb72434156071
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85027
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: V Sowmya <v.sowmya@intel.com>
Reviewed-by: Dinesh Gehlot <digehlot@google.com>
This commit is contained in:
Subrata Banik 2024-11-08 01:41:56 +05:30
commit 03ebbb045f
1 changed files with 12 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

34
src/soc/intel/common/basecode/ramtop/ramtop.c
View file

@ -181,25 +181,19 @@ void early_ramtop_enable_cache_range(void)
}
size_t ramtop_size = get_ramtop_size();
/*
* Background: Some SoCs have a critical bug inside the NEM logic which is responsible
* for mapping cached memory to physical memory during tear down and
* eventually malfunctions if the number of cache sets is not a power of two.
* This can lead to runtime hangs.
*
* Workaround: To mitigate this issue on affected SoCs, we force the MTRR type to
* WC (Write Combining) unless the cache set count is a power of two.
* This change alters caching behavior but prevents the runtime failures.
*/
unsigned int mtrr_type = MTRR_TYPE_WRCOMB;
/*
* Late romstage (including FSP-M post-memory initialization) needs to be
* executed from cache for performance reasons. This requires caching
* `ramtop_size`, which encompasses both FSP reserved memory and the CBMEM
* range, to guarantee sufficient cache coverage for late romstage.
*/
if (is_cache_sets_power_of_two())
mtrr_type = MTRR_TYPE_WRBACK;
if (!ramtop_size)
return;
set_var_mtrr(mtrr, ramtop - ramtop_size, ramtop_size, mtrr_type);
/*
* INTEL RECOMMENDATION: Early Ramtop Caching Configuration
*
* Configuring the Early Caching Ramtop range as Write-Back (WB) before
* memory initialization is NOT RECOMMENDED. Speculative execution within
* this WB range can lead to issues. WB configuration should be applied
* to this range ONLY AFTER memory initialization is complete.
*
* To enable Ramtop caching before memory initialization, use Write-Combining
* (WC) instead of Write-Back (WB).
*/
set_var_mtrr(mtrr, ramtop - ramtop_size, ramtop_size, MTRR_TYPE_WRCOMB);
}