From 03b5e88a66b9c96df2ef3d9ce5ba4a62a8bb2447 Mon Sep 17 00:00:00 2001 From: "Ronald G. Minnich" Date: Fri, 13 Dec 2013 19:31:05 -0800 Subject: [PATCH] nyan: clean up a comment regarding video Make it clear that we are doing little more than toggling some GPIOs. Also remove any hint that we think romstage is in RW; that's some ways off. BUG=chrome-os-partner:24548 TEST=just a comment change, it still builds. BRANCH=None Change-Id: Ie2bd051fb99ed86d588f6dfc2e80aea1edc8f07c Signed-off-by: Ronald G. Minnich Reviewed-on: https://chromium-review.googlesource.com/180161 Reviewed-by: Gabe Black Commit-Queue: Ronald Minnich Tested-by: Ronald Minnich --- src/mainboard/google/nyan/romstage.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/mainboard/google/nyan/romstage.c b/src/mainboard/google/nyan/romstage.c index ecfa20d898..ea40388823 100644 --- a/src/mainboard/google/nyan/romstage.c +++ b/src/mainboard/google/nyan/romstage.c @@ -107,12 +107,15 @@ void main(void) dcache_invalidate_all(); dcache_mmu_enable(); - /* for quality of the user interface, it's important to get + /* For quality of the user experience, it's important to get * the video going ASAP. Because there are long delays in some * of the powerup steps, we do some very early setup here in - * romstage. We don't do this in the bootblock because video - * setup is finicky and subject to change; hence, we do it as - * early as we can in the RW stage, but never in the RO stage. + * romstage. The only thing setup_display does is manage + * 4 GPIOs, under control of the config struct members. + * In general, it is safe to enable panel power, and disable + * anything related to the backlight. If we get something wrong, + * we can easily fix it in ramstage by further GPIO manipulation, + * so we feel it is ok to do some setting at this point. */ const struct device *soc = dev_find_slot(DEVICE_PATH_CPU_CLUSTER, 0);